Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for 'Training An Agent' page #1281

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chr0nikler
Copy link

@chr0nikler chr0nikler commented Dec 23, 2024

Description

"Training An Agent" code does not match visual outputs. Short term solution is to change visualization code to match outputs. Long-term proposal to change page to be specifically about agent training and let users go to tutorial for black jack, or do away with page entirely. If keeping page, could turn into a 2-arm bandit e-greedy bandit.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation only change (no code changed)

Screenshots

Before After
Screenshot 2024-12-23 at 4 23 44 PM Screenshot 2024-12-23 at 4 23 29 PM

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant